Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Video and Image Handling, Add Interactive Query Mode #93

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

0iui0
Copy link

@0iui0 0iui0 commented Jul 3, 2024

Dear Project Maintainer,

I am excited to submit a pull request for the recent enhancements I have made to the project. The changes include:

  1. Improved Video and Image Directory Handling: The read_video_from_path function has been updated to support both video files and directories containing images. It intelligently detects the type of path provided and processes it accordingly, ensuring seamless integration of various media sources.

  2. Interactive Query Mode for User-Defined Tracking: A new feature has been added to allow users to define tracking queries interactively by clicking on video frames. This is enabled through the --interactive_query flag in the command-line interface, providing users with the flexibility to specify tracking targets based on their specific requirements.

  3. Updated README.md: The documentation has been updated to include instructions for running offline demos with grid sampling on images and videos. It also provides details on how to use the interactive query feature for point selection using mouse clicks.

These enhancements aim to improve the user experience and expand the functionality of the project. I have thoroughly tested these changes and ensured they integrate smoothly with the existing codebase.

Please review the changes at your convenience. I am looking forward to your feedback and am available to discuss any aspects of the pull request.

Best regards,

0iui0

@facebook-github-bot
Copy link

Hi @0iui0!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants