[WIP] Robotics Coordinate System Migration #2523
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR represents a prototype of converting the default Habitat coordinate system to robotics conventions (Z-up, X-forward).
To make this work several systems needed to be changed:
CoordinateFrame
andESP_UP
/ESP_FRONT
logic and defaults changed to fix a bug and correctly represent the new defaults.up
andfront
vectors in their own local asset coordindate system. This is now correctly converted to the new coordinate system.TODO:
How Has This Been Tested
Added examples/coordinate_system.py to test this migration.
Example. Note the colored axis (RGB == XYZ) indicating that we're now in robotics conventions!:
Types of changes
Checklist