Fixed the bug to access tensor stride #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
kingchc,
louisfeng,
sunghlin,
shengbao-zheng and
briancoutinho
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60642585 |
|
This pull request was exported from Phabricator. Differential Revision: D60642585 |
shengfukevin
force-pushed
the
export-D60642585
branch
from
f99d5ed
to
efc853d
Compare
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebookresearch#150 There is a bug to access tensor stride. The current implementation uses the index of the input tensor to access node.tensor_strides. However node.tensor_strides is for all input variables including non tensor variables. So the fix is to get the list of tensor stride, then uses the index of the input tensor to access the list of tensor stride. Differential Revision: D60642585
|
This pull request was exported from Phabricator. Differential Revision: D60642585 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebookresearch#150 There is a bug to access tensor stride. The current implementation uses the index of the input tensor to access node.tensor_strides. However node.tensor_strides is for all input variables including non tensor variables. So the fix is to get the list of tensor stride, then uses the index of the input tensor to access the list of tensor stride. Differential Revision: D60642585
shengfukevin
force-pushed
the
export-D60642585
branch
from
efc853d
to
07331b4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60642585 |
shengfukevin
added a commit
to shengfukevin/param
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebookresearch#150 There is a bug to access tensor stride. The current implementation uses the index of the input tensor to access node.tensor_strides. However node.tensor_strides is for all input variables including non tensor variables. So the fix is to get the list of tensor stride, then uses the index of the input tensor to access the list of tensor stride. Differential Revision: D60642585
shengfukevin
force-pushed
the
export-D60642585
branch
from
07331b4
to
431b634
Compare
Summary: Pull Request resolved: facebookresearch#150 There is a bug to access tensor stride. The current implementation uses the index of the input tensor to access node.tensor_strides. However node.tensor_strides is for all input variables including non tensor variables. So the fix is to get the list of tensor stride, then uses the index of the input tensor to access the list of tensor stride. Reviewed By: briancoutinho Differential Revision: D60642585
|
This pull request was exported from Phabricator. Differential Revision: D60642585 |
shengfukevin
force-pushed
the
export-D60642585
branch
from
431b634
to
78036a4
Compare
|
This pull request has been merged in 58ce6eb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There is a bug to access tensor stride. The current implementation uses the index of the input tensor to access node.tensor_strides. However node.tensor_strides is for all input variables including non tensor variables. So the fix is to get the list of tensor stride, then uses the index of the input tensor to access the list of tensor stride.
Differential Revision: D60642585