Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable complete BlockDiagonalGappyKeysMask and BlockDiagonalPaddedKey Support on CK #1108

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Enable complete BlockDiagonalGappyKeysMask and BlockDiagonalPaddedKey Support on CK #1108

merged 1 commit into from
Sep 20, 2024

Conversation

qianfengz
Copy link
Contributor

Some Change to the xformers/ops/fmha/ck.py so that correct seqstart_k and seqlen_k can be passed to the C++ codes for

  • BlockDiagonalGappyKeysMask
  • BlockDiagonalPaddedKey

And their derived attn-bias types.

The change has passed all tests in

pytest tests/test_mem_eff_attention.py::test_forward -k "not triton"  -k "not flshattF"  -k "not fa2F"

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2024
@bottler bottler self-requested a review September 20, 2024 09:21
@bottler bottler merged commit 8c24081 into facebookresearch:main Sep 20, 2024
6 of 7 checks passed
@qianfengz qianfengz deleted the tiny_upstream_pr branch September 26, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bottler bottler bottler approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qianfengz @bottler @facebook-github-bot