Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nesting ampersand #269

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add support for nesting ampersand #269

merged 2 commits into from
Jul 9, 2024

Conversation

facelessuser
Copy link
Owner

When used outside the context of nesting, ampersand is treated as the scoping root.

@facelessuser
Add support for nesting ampersand
b97c84b 
When used outside the context of nesting, ampersand is treated as the
scoping root.
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: API Related to the API. C: css-matching Related to CSS matching. C: css-parsing Related to CSS parsing. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. labels Jul 9, 2024
@facelessuser
Copy link
Owner Author

This is being added as browsers currently support this.

@facelessuser
Copy link
Owner Author

This does not mean nested selectors are supported, only that the nesting syntax & when used outside of nesting context has meaning per the spec.

@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Jul 9, 2024
@facelessuser facelessuser merged commit c811bdf into main Jul 9, 2024
19 checks passed
@facelessuser facelessuser deleted the feature/amp branch July 9, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: API Related to the API. C: css-matching Related to CSS matching. C: css-parsing Related to CSS parsing. C: docs Related to documentation. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facelessuser @gir-bot