-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license definition in project metadata #275
Conversation
I'm not doubting your claim, but I'm using the recommendation as referenced here via hatch, which is the package tool I use: https://hatch.pypa.io/latest/config/metadata/#license. While I do see the null in the metadata you are referencing, I also see that PyPI seems to have no issue determining the license: Maybe this is because it falls back to pulling the data from the |
It seems this may have been an addition made after hatch implemented license support... |
That explains why another package that uses hatch as well specifies it the same way. The hatch documentation refers to PEP 639 which has the status draft (see also this discussion: https://discuss.python.org/t/pep-639-round-3-improving-license-clarity-with-better-package-metadata/53020) I had proposed Regarding PyPI: I suspect that this information is being pulled from the license classifier. Could be a fallback though as you said. |
It may be something I need to create an issue for on hatch first. |
I'll play around and make sure everything seems sound, and if so, I can push this through. Regardless, this will have to be reported up to hatch as well. |
I'm holding off for a more formal response from parties involved in this area. While fixing the packaging null might be nice, this is not a huge deal to me. I want to make sure I properly understand the situation before changing anything. |
Here is an interesting note: squidfunk/mkdocs-material#4392 (comment) |
I will note that it seems that those who use To be honest, if it isn't used on PyPI itself, I'm questioning who is even looking at this data. It doesn't seem to be officially used, maybe 3rd parties are and are expecting it to be stable? Ultimately, I'm not against changing this, I just don't want to change it if I'm going to want to change it back later because things change. Additionally, this doesn't seem to affect anything related to Python packaging as classifiers is currently used and it seems |
I guess PEP 639 has now moved into being provisional. I'm questioning whether it is really worth changing our convention at this point. |
Thanks for creating an issue on the hatch repo. I am not too familiar with packaging and understand it a bit better now after reading a few resources. Given that hatch already supports PEP 639 (as the first build backend) it makes sense the way it is specified. Closing this PR. |
The license definition in
pyproject.toml
is not valid according to the specification.As a result, the PyPI API returns
license: null
for this package: https://pypi.org/pypi/soupsieve/jsonThis PR fixes this.