Solve PHP 8.4 deprecation (implicit nullable argument type)

facile-it · Nov 7, 2024 · f39d54b · f39d54b
1 parent 3335e68
commit f39d54b
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/Configuration/CoverageConfiguration.php b/src/Configuration/CoverageConfiguration.php
@@ -23,9 +23,9 @@
 
 class CoverageConfiguration extends ParallelConfiguration
 {
-    public function __construct(bool $createPublicServiceAliases = false)
+    public function __construct(?bool $createPublicServiceAliases = false)
     {
-        parent::__construct($createPublicServiceAliases);
+        parent::__construct($createPublicServiceAliases ?? false);
         $this->containerDefinition = new CoverageContainerDefinition();
     }
 

diff --git a/src/Filter/Filter.php b/src/Filter/Filter.php
@@ -70,7 +70,7 @@ public function filterTestFiles(): array
         return $this->filterBySuffix($aggregatedFiles, $this->testSuffix);
     }
 
-    private function testSuitePassFilter(\DOMElement $testSuiteNode, string $testSuiteFilter = null): bool
+    private function testSuitePassFilter(\DOMElement $testSuiteNode, ?string $testSuiteFilter = null): bool
     {
         if ($testSuiteFilter === null) {
             return true;
@@ -161,7 +161,7 @@ private function addFileToAggregateArray(array &$aggregatedFiles, string $fileNa
     private function getDOMNodeAttribute(
         \DOMElement $testSuiteNode,
         string $nodeName,
-        string $defaultValue = null
+        ?string $defaultValue = null
     ): string {
         /** @psalm-suppress RedundantCondition */
         foreach ($testSuiteNode->attributes as $attrName => $attrNode) {

diff --git a/src/Logs/ValueObject/TestMethod.php b/src/Logs/ValueObject/TestMethod.php
@@ -17,7 +17,7 @@ class TestMethod extends Test
     public function __construct(
         public readonly string $className,
         public readonly string $methodName,
-        string $fullName = null,
+        ?string $fullName = null,
     ) {
         parent::__construct($fullName ?? $this->className . '::' . $this->methodName);
     }

diff --git a/src/Runner/Runner.php b/src/Runner/Runner.php
@@ -118,7 +118,7 @@ private function createChunkedProcessQueue(): void
         }
     }
 
-    public function pushToPipeline(ProcessTerminated $event = null): void
+    public function pushToPipeline(?ProcessTerminated $event = null): void
     {
         if ($event && $this->chunkSize->isChunked()) {
             $process = $event->getProcess();

diff --git a/tests/Unit/Logs/EqualsToken.php b/tests/Unit/Logs/EqualsToken.php
@@ -13,7 +13,7 @@ class EqualsToken implements TokenInterface, \Stringable
 
     private string $string;
 
-    public function __construct(private readonly mixed $value, StringUtil $util = null)
+    public function __construct(private readonly mixed $value, ?StringUtil $util = null)
     {
         $this->util = $util ?? new StringUtil();
     }