Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashPassword and checkPw functions #63

Open
mattlub opened this issue Aug 24, 2017 · 2 comments
Open

hashPassword and checkPw functions #63

mattlub opened this issue Aug 24, 2017 · 2 comments

Comments

@mattlub
Copy link
Collaborator

mattlub commented Aug 24, 2017

hashPassword and checkPw functions in this file:
https://github.com/facn2/facnrecipev4/blob/master/src/models/queries.js#L31-L33

They shouldn't really be in the queries file, and anyway they are not really necessary.

@rinoma
Copy link
Collaborator

rinoma commented Aug 24, 2017

could you iterate more? how would you do it?

@mattlub
Copy link
Collaborator Author

mattlub commented Aug 24, 2017

By 'they're not necessary', I just meant they don't add anything to the functions they wrap. They belong in a different file, maybe helpers or something. But I would just use the original functions like bcrypt.compare(.. instead of wrapping them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants