added checks for nil pointer errors

factly · Dec 23, 2022 · 19e7ee4 · surajmn1 · Dec 23, 2022 · 19e7ee4
1 parent 5d500fb
commit 19e7ee4
Show file tree

Hide file tree

Showing 11 changed files with 26 additions and 10 deletions.
diff --git a/server/service/core/action/page/create.go b/server/service/core/action/page/create.go
@@ -127,10 +127,13 @@ func create(w http.ResponseWriter, r *http.Request) {
 		FooterCode:       page.FooterCode,
 		SpaceID:          uint(sID),
 		DescriptionAMP:   page.DescriptionAMP,
-		MigrationID:      page.MigrationID,
 		MigratedHTML:     page.MigratedHTML,
 	}
 
+	if page.MigrationID != nil {
+		result.Post.MigrationID = *page.MigrationID
+	}
+
 	if len(page.TagIDs) > 0 {
 		config.DB.Model(&model.Tag{}).Where(page.TagIDs).Find(&result.Post.Tags)
 	}

diff --git a/server/service/core/action/page/route.go b/server/service/core/action/page/route.go
@@ -31,7 +31,7 @@ type page struct {
 	FooterCode       string         `json:"footer_code"`
 	MetaFields       postgres.Jsonb `json:"meta_fields" swaggertype:"primitive,string"`
 	DescriptionAMP   string         `json:"description_amp"`
-	MigrationID      uint           `json:"migration_id"`
+	MigrationID      *uint          `json:"migration_id"`
 	MigratedHTML     string         `json:"migrated_html"`
 	SpaceID          uint           `json:"space_id"`
 	CategoryIDs      []uint         `json:"category_ids"`

diff --git a/server/service/core/action/page/update.go b/server/service/core/action/page/update.go
@@ -191,10 +191,12 @@ func update(w http.ResponseWriter, r *http.Request) {
 		"header_code":        page.HeaderCode,
 		"footer_code":        page.FooterCode,
 		"is_featured":        page.IsFeatured,
-		"migration_id":       page.MigrationID,
 		"description_amp":    page.DescriptionAMP,
 		"migrated_html":      page.MigratedHTML,
 	}
+	if page.MigrationID != nil {
+		updateMap["migration_id"] = *page.MigrationID
+	}
 
 	result.Post.FeaturedMediumID = &page.FeaturedMediumID
 	if page.FeaturedMediumID == 0 {

diff --git a/server/service/core/action/post/create.go b/server/service/core/action/post/create.go
@@ -218,10 +218,13 @@ func createPost(ctx context.Context, post post, status string, r *http.Request)
 		MetaFields:       post.MetaFields,
 		SpaceID:          uint(sID),
 		DescriptionAMP:   post.DescriptionAMP,
-		MigrationID:       post.MigrationID,
 		MigratedHTML:     post.MigratedHTML,
 	}
 
+	if post.MigrationID != nil {
+		result.Post.MigrationID = *post.MigrationID
+	}
+
 	if status == "publish" {
 		if post.PublishedDate == nil {
 			currTime := time.Now()

diff --git a/server/service/core/action/post/route.go b/server/service/core/action/post/route.go
@@ -34,7 +34,7 @@ type post struct {
 	FooterCode       string         `json:"footer_code"`
 	MetaFields       postgres.Jsonb `json:"meta_fields" swaggertype:"primitive,string"`
 	DescriptionAMP   string         `json:"description_amp"`
-	MigrationID      uint           `json:"migration_id"`
+	MigrationID      *uint           `json:"migration_id"`
 	MigratedHTML     string         `json:"migrated_html"`
 	CategoryIDs      []uint         `json:"category_ids"`
 	TagIDs           []uint         `json:"tag_ids"`

diff --git a/server/service/core/action/post/update.go b/server/service/core/action/post/update.go
@@ -201,11 +201,14 @@ func update(w http.ResponseWriter, r *http.Request) {
 		"header_code":        post.HeaderCode,
 		"footer_code":        post.FooterCode,
 		"meta_fields":        post.MetaFields,
-		"migration_id":       post.MigrationID,
 		"description_amp":    post.DescriptionAMP,
 		"migrated_html":      post.MigratedHTML,
 	}
 
+	if post.MigrationID != nil {
+		updateMap["migration_id"] = *post.MigrationID
+	}
+
 	result.Post.FeaturedMediumID = &post.FeaturedMediumID
 	if post.FeaturedMediumID == 0 {
 		updateMap["featured_medium_id"] = nil

diff --git a/server/service/core/model/post.go b/server/service/core/model/post.go
@@ -35,7 +35,7 @@ type Post struct {
 	HeaderCode       string         `gorm:"column:header_code" json:"header_code"`
 	FooterCode       string         `gorm:"column:footer_code" json:"footer_code"`
 	DescriptionAMP   string         `gorm:"column:description_amp" json:"description_amp"`
-	MigrationID     uint           `gorm:"column:migration_id;default:false;" json:"migration_id"`
+	MigrationID      uint           `gorm:"column:migration_id;default:NULL;" json:"migration_id"`
 	MigratedHTML     string         `gorm:"column:migrated_html" json:"migrated_html"`
 	MetaFields       postgres.Jsonb `gorm:"column:meta_fields" json:"meta_fields" swaggertype:"primitive,string"`
 	Tags             []Tag          `gorm:"many2many:post_tags;" json:"tags"`

diff --git a/server/service/fact-check/action/claim/create.go b/server/service/fact-check/action/claim/create.go
@@ -135,7 +135,7 @@ func create(w http.ResponseWriter, r *http.Request) {
 		SpaceID:         uint(sID),
 		MediumID:        mediumID,
 		DescriptionAMP:  claim.DescriptionAMP,
-		MigrationID:      claim.MigrationID,
+		MigrationID:     claim.MigrationID,
 		MigratedHTML:    claim.MigratedHTML,
 	}
 

diff --git a/server/service/fact-check/action/claim/route.go b/server/service/fact-check/action/claim/route.go
@@ -29,7 +29,7 @@ type claim struct {
 	HeaderCode     string         `json:"header_code"`
 	FooterCode     string         `json:"footer_code"`
 	DescriptionAMP string         `json:"description_amp"`
-	MigrationID    uint           `json:"migration_id"`
+	MigrationID    *uint           `json:"migration_id"`
 	MigratedHTML   string         `json:"migrated_html"`
 }
 

diff --git a/server/service/fact-check/action/claim/update.go b/server/service/fact-check/action/claim/update.go
@@ -161,6 +161,11 @@ func update(w http.ResponseWriter, r *http.Request) {
 		"description_amp":  claim.DescriptionAMP,
 		"migrated_html":    claim.MigratedHTML,
 	}
+
+	if claim.MigrationID != nil {
+		updateMap["migration_id"] = *claim.MigrationID
+	}
+
 	if claim.MediumID == 0 {
 		updateMap["medium_id"] = nil
 	}

diff --git a/server/service/fact-check/model/claim.go b/server/service/fact-check/model/claim.go
@@ -23,7 +23,7 @@ type Claim struct {
 	Description     postgres.Jsonb `gorm:"column:description" json:"description" swaggertype:"primitive,string"`
 	DescriptionHTML string         `gorm:"column:description_html" json:"description_html,omitempty"`
 	DescriptionAMP  string         `gorm:"column:description_amp" json:"description_amp"`
-	MigrationID     uint           `gorm:"column:migration_id;default:false;" json:"migration_id"`
+	MigrationID     *uint          `gorm:"column:migration_id;default:NULL;" json:"migration_id"`
 	MigratedHTML    string         `gorm:"column:migrated_html" json:"migrated_html"`
 	ClaimantID      uint           `gorm:"column:claimant_id" json:"claimant_id"`
 	Claimant        Claimant       `json:"claimant"`