Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/change windows injector to inject all mods instead of just librivets #10

Conversation

notnotmelon
Copy link
Member

I made some changes to the design of librivets on windows. It turns out that if you try to inject a dll from inside an injected dll then windows will attach the grandfather dll to the child dll and not factorio.exe
From there, factorio is free to delete it from the temp folder and factorio crashes whenever a detour is invoked from the deleted file.
The end result is that I'm now instead injecting all mods from rivets-injector

@notnotmelon notnotmelon requested a review from fgardt August 15, 2024 22:59
@notnotmelon notnotmelon merged commit 0a0d72b into main Aug 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant