feat: Update and expand Chromecast device families #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
May 9, 2024
This uses a preview of faisalman/ua-parser-js#724 to differentiate between Chromecast models in Karma.
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
May 9, 2024
This uses a preview of faisalman/ua-parser-js#724 to differentiate between Chromecast models in Karma.
avelad
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
May 13, 2024
This uses a preview of faisalman/ua-parser-js#724 to differentiate between Chromecast models in Karma.
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
May 31, 2024
This uses a preview of faisalman/ua-parser-js#724 to differentiate between Chromecast models in Karma.
faisalman
force-pushed
the
update-chromecast-family
branch
from
f2c7ff0 to
f0b56be
Compare
faisalman
approved these changes
Jun 2, 2024
|
Any reason we can't merge this? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Feature
Description
Update and expand Chromecast device families. This adds support to differentiate between types of Chromecast devices and operating systems, and fixes erroneous classification of Android-based Chromecasts.
Test
Extracted several current useragent strings from various device types in a lab, then added them to the automated tests in us-parser-js. These tests are passing.
Impact
No breaking changes AFAICT.
Other Info
I'm a current member of the Chromecast team at Google, as well as the TL for the open source Shaka Player. We test our video player on many, many devices in a lab using Karma, which uses ua-parser-js to match test results to each device. We need these changes to differentiate between the Chromecast devices in our lab.