fix: set sideEffect to false in package.json

[missing1984]

Ran into treeshaking issue in Webpack and found sideEffect is not declared in package.json. https://webpack.js.org/configuration/optimization/#optimizationsideeffects

This PR is setting sideEffect: false in package.json in order to enable Treeshaking. I've go over the code and it doesn't seems we have side effects so it should be safe to set it to false.

[xDivisionByZerox]

I think our UniqueStore has side effects.

See line 143, we store a result in a global store (at least if we use the default store).

faker/src/modules/unique/unique.ts

Lines 142 to 145 in f78843e

	if (compare(store, result) === -1 && exclude.indexOf(result) === -1) {
	store[result] = result;
	options.currentIterations = 0;
	return result;

Or am I misinterpreting?

[codecov]

Codecov Report

Merging #1305 (287cae9) into main (7b18404) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2160     2160              
  Lines      240614   240614              
  Branches     1017     1013       -4     
==========================================
- Hits       239730   239706      -24     
- Misses        863      887      +24     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/internet/user-agent.ts	81.74% <0.00%> (-6.35%)	⬇️

[missing1984]

I think our UniqueStore has side effects.

See line 143, we store a result in a global store (at least if we use the default store).

faker/src/modules/unique/unique.ts

Lines 142 to 145 in f78843e

	if (compare(store, result) === -1 && exclude.indexOf(result) === -1) {
	store[result] = result;
	options.currentIterations = 0;
	return result;

Or am I misinterpreting?

It's fine as this store is local to the package and does not create sideEffect outside of package scope

[xDivisionByZerox]

It's fine as this store is local to the package and does not create sideEffect outside of package scope

Ok, I see. The scope is per package, my bad.

[Shinigami92]

Read a bit about what that is, and yeah, looks like its file for us to set that

@ST-DDT would you like to check independent from me if you are also okay with this?
That way I cannot bias you with my knowledge

[ST-DDT]

I have trouble understanding, what this requires exactly.
The documentation isn't that helpful either and some SO comments actually contradict the examples.
I need some more time and probably some tests to determine, whether this is safe to apply.

[Shinigami92]

Based on my comment I send here: mitodl/open-discussions#3714 (comment)
I'm not so sure anymore if this PR would help in anyway even if we would merge it...
I'm tempted to close this and forward to our v8 solution which will fix this in a much higher order