feat(cors): disallow cors_enable & additional CORSMiddleware combo
#2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytas7
commented
Dec 16, 2023
| @@ -461,10 +462,28 @@ def add_middleware(self, middleware: object) -> None: | |||
| # the chance that middleware may be None. | |||
| if middleware: | |||
| try: | |||
| self._unprepared_middleware += middleware | |||
| middleware = list(middleware) # type: ignore | |||
There was a problem hiding this comment.
Bonus points if anyone knows how type this correctly. Since we optionally allow passing in any object, mypy complains:
No overload variant of "list" matches argument type "object" [call-overload]
There was a problem hiding this comment.
I don't think you can. Maybe you can use
try:
if TYPE_CHECKING:
assert isinstance(middleware, Iterable)
...But I'm not sure it's worth it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6876 6880 +4
Branches 1098 1099 +1
=========================================
+ Hits 6876 6880 +4 ☔ View full report in Codecov by Sentry. |
CaselIT
approved these changes
Dec 16, 2023
| @@ -461,10 +462,28 @@ def add_middleware(self, middleware: object) -> None: | |||
| # the chance that middleware may be None. | |||
| if middleware: | |||
| try: | |||
| self._unprepared_middleware += middleware | |||
| middleware = list(middleware) # type: ignore | |||
There was a problem hiding this comment.
I don't think you can. Maybe you can use
try:
if TYPE_CHECKING:
assert isinstance(middleware, Iterable)
...But I'm not sure it's worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1977.