-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parse_header): provide our own implementation of parse_header()
#2217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 63 +1
Lines 6888 6930 +42
Branches 1099 1109 +10
=========================================
+ Hits 6888 6930 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have just glanced at the mediatypes module since it's copied from the stdlib.
Did you make changes to it?
+ address 1 review comment
@CaselIT yes, I wrote a much simpler implementation for the common case, and fall back to the old stdlib impl for more complex cases. |
Ok, I'll take a better look later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok but could maybe use one more test
I have another branch which also introduces Cython's "pure Python mode" in order to speed up
parse_header()
, but we can circle back on that optimization in Falcon 4.1.I'm also planning to reimplement the parts of
mimeparse
that we actually use, and unvendor it completely.Fixes #2066