-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add capemconfig #828
add capemconfig #828
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: data-dude The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@data-dude: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey @data-dude Can you sign off your commit, please? |
Signed-off-by: Thomas C. Gullo <[email protected]>
…capemconfig sign off
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If I didn't set caPEMBundle to spaces I ran into ssl errors with k8s-metacollector. And there's no way to set the caPEMBundle. This change fixed it for me. By default k8s-metacollector doesn't use ssl but it seems the plugin assumes you are using ssl if caPEMBundle isn't set to spaces. I just now signed the branch change. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
close this and create a new one |
/kind bug
/kind 4.19.0
/area falco-chart
What this PR does / why we need it:
If you don't set the caPEMBundle to spaces it causes tls issues