-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(userspace/libsinsp/filter/parser): fix grammar doc #2239
Conversation
The spaces after the operator tokens were intended to indicate operators that mandate a whitespace character to be followed. Co-authored-by: Jason Dellaluce <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
/milestone 0.20.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2239 +/- ##
=======================================
Coverage 75.11% 75.12%
=======================================
Files 276 276
Lines 34395 34394 -1
Branches 5923 5921 -2
=======================================
+ Hits 25836 25837 +1
+ Misses 8559 8557 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
As correctly reported to me by @jasondellaluce , the spaces after the operator tokens were intended to indicate operators that mandate a whitespace character to be followed.
Also, re-add
glob
, which was removed by mistake.Follow up #2237
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: