Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(userspace/libsinsp/filter/parser): fix grammar doc #2239

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Jan 16, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

As correctly reported to me by @jasondellaluce , the spaces after the operator tokens were intended to indicate operators that mandate a whitespace character to be followed.
Also, re-add glob, which was removed by mistake.

Follow up #2237

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

The spaces after the operator tokens were intended to indicate operators that mandate a whitespace character to be followed.

Co-authored-by: Jason Dellaluce <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr
Copy link
Member Author

leogr commented Jan 16, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (8e1b1a3) to head (9808e62).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   75.11%   75.12%           
=======================================
  Files         276      276           
  Lines       34395    34394    -1     
  Branches     5923     5921    -2     
=======================================
+ Hits        25836    25837    +1     
+ Misses       8559     8557    -2     
Flag Coverage Δ
libsinsp 75.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana added the lgtm label Jan 16, 2025
Copy link

Perf diff from master - unit tests

     3.25%     -0.73%  [.] sinsp_thread_manager::find_thread
    11.11%     -0.54%  [.] sinsp::next
     9.49%     +0.42%  [.] sinsp_parser::reset
     1.42%     +0.42%  [.] sinsp_evt_filter::sinsp_evt_filter
     1.31%     -0.33%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     3.39%     +0.32%  [.] sinsp_evt::load_params
     1.34%     +0.29%  [.] scap_event_decode_params
     0.62%     -0.26%  [.] sinsp_parser::parse_open_openat_creat_exit
     0.63%     -0.25%  [.] thread_group_info::get_first_thread
     1.94%     +0.25%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0169         +0.0168           144           147           144           147
BM_sinsp_split_median                                          +0.0123         +0.0122           144           146           144           146
BM_sinsp_split_stddev                                          +4.7474         +4.7481             1             3             1             3
BM_sinsp_split_cv                                              +4.6519         +4.6533             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0222         +0.0221            57            58            57            58
BM_sinsp_concatenate_paths_relative_path_median                +0.0222         +0.0221            57            58            57            58
BM_sinsp_concatenate_paths_relative_path_stddev                +0.3283         +0.3265             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2994         +0.2978             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0410         +0.0409            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0337         +0.0336            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +6.7697         +6.7629             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +6.4639         +6.4582             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0456         +0.0455            56            59            56            59
BM_sinsp_concatenate_paths_absolute_path_median                +0.0476         +0.0475            56            59            56            59
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6631         -0.6626             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6778         -0.6773             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0258         +0.0257           390           400           390           400
BM_sinsp_split_container_image_median                          +0.0267         +0.0266           390           400           390           400
BM_sinsp_split_container_image_stddev                          -0.5995         -0.5995             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.6096         -0.6095             0             0             0             0

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f216920 into master Jan 16, 2025
49 checks passed
@poiana poiana deleted the leogr-patch-1 branch January 16, 2025 13:20
@FedeDP FedeDP mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants