fix(bpf): add tail call to sendmmsg filler

[therealbobo]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

I found a verifier failure within the legacy bpf driver with a debian 4.19 kernel. This should fix it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[github-actions]

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

[github-actions]

Perf diff from master - unit tests

    12.90%     -0.88%  [.] sinsp::next
     5.22%     +0.60%  [.] next_event_from_file
     2.39%     +0.37%  [.] sinsp_parser::process_event
     3.63%     +0.35%  [.] gzfile_read
     7.47%     +0.32%  [.] sinsp_evt::get_type
     1.13%     -0.29%  [.] sinsp_evt::get_syscall_return_value
     0.64%     +0.26%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     0.48%     +0.25%  [.] scap_event_has_large_payload
     2.75%     -0.25%  [.] sinsp_thread_manager::find_thread
     1.70%     -0.24%  [.] sinsp::fetch_next_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0238         +0.0239           144           147           144           147
BM_sinsp_split_median                                          +0.0255         +0.0256           144           147           144           147
BM_sinsp_split_stddev                                          +1.0663         +1.0646             1             1             1             1
BM_sinsp_split_cv                                              +1.0184         +1.0165             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0812         +0.0813            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0788         +0.0788            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7180         -0.7191             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7392         -0.7402             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0044         -0.0043            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0067         -0.0066            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.2676         +0.2685             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.2732         +0.2740             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1246         +0.1247            57            64            57            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.1300         +0.1301            57            64            57            64
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.6830         +1.6838             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.3858         +1.3863             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0093         -0.0092           392           388           392           388
BM_sinsp_split_container_image_median                          -0.0110         -0.0109           392           388           392           388
BM_sinsp_split_container_image_stddev                          +0.0288         +0.0291             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.0385         +0.0387             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.33%. Comparing base (5a0302c) to head (78c5d36).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
- Coverage   75.34%   75.33%   -0.01%     
==========================================
  Files         279      279              
  Lines       34369    34369              
  Branches     5874     5875       +1     
==========================================
- Hits        25894    25893       -1     
- Misses       8475     8476       +1     

Flag	Coverage Δ
libsinsp	75.33% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

I will run kernel-testing CI against this PR.

[FedeDP]

/milestone next-driver

[FedeDP]

All green! LGTM! Thanks for the fix!

[FedeDP]

/approve

[poiana]

LGTM label has been added.

Git tree hash: 729681c6558c9fdd4d1e2b9528d551fe2ddbb430

[Molter73]

Thanks for this one!

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, Molter73, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• driver/OWNERS [FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[FedeDP]

/unhold