Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(libsinsp): remove unused plugin table API functions #2269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irozzo-1A
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Clean up unused functions from the table API. Fixes some build warnings.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Clean-up unused functions from the table API.

Signed-off-by: Iacopo Rozzo <[email protected]>
@poiana
Copy link
Contributor

poiana commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: irozzo-1A
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Feb 5, 2025

/milestone 0.21.0
/cc @jasondellaluce

@poiana poiana requested a review from jasondellaluce February 5, 2025 07:28
@poiana poiana added this to the 0.21.0 milestone Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Perf diff from master - unit tests

    12.09%     +1.69%  [.] sinsp::next
    10.42%     -0.80%  [.] sinsp_parser::reset
     4.00%     -0.58%  [.] gzfile_read
     2.85%     +0.42%  [.] sinsp_evt::load_params
     2.12%     -0.36%  [.] next
     5.32%     -0.31%  [.] next_event_from_file
     1.35%     +0.30%  [.] scap_event_decode_params
     8.02%     -0.29%  [.] sinsp_evt::get_type
     2.53%     +0.27%  [.] sinsp_parser::process_event
     1.21%     -0.27%  [.] sinsp_parser::event_cleanup

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0343         -0.0342           152           147           152           147
BM_sinsp_split_median                                          -0.0396         -0.0396           153           147           153           147
BM_sinsp_split_stddev                                          -0.5210         -0.5208             2             1             2             1
BM_sinsp_split_cv                                              -0.5040         -0.5039             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0787         -0.0786            62            57            62            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0837         -0.0836            62            57            62            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8625         -0.8623             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8507         -0.8505             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0021         -0.0022            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0025         -0.0025            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2754         -0.2771             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2739         -0.2755             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0656         -0.0656            61            57            61            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.0772         -0.0772            62            57            62            57
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8775         -0.8777             2             0             2             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.8689         -0.8692             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0400         -0.0399           404           388           404           388
BM_sinsp_split_container_image_median                          -0.0406         -0.0405           405           388           405           388
BM_sinsp_split_container_image_stddev                          +0.6981         +0.6985             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.7688         +0.7690             0             0             0             0

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.29%. Comparing base (356d27a) to head (4cea338).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2269   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files         279      279           
  Lines       34389    34389           
  Branches     5878     5878           
=======================================
  Hits        25893    25893           
  Misses       8496     8496           
Flag Coverage Δ
libsinsp 75.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants