Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 391 remove unused imports #394

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

gabrielziegler3
Copy link
Contributor

@gabrielziegler3 gabrielziegler3 commented Oct 24, 2019

Proposed Changes

#391 Remove 18 unused imports to improve code quality.

image

Checklist

Put an x in the boxes that apply. If you're confused about any of the following topics, ask us. We're here to help you!

  • This Pull Request has a significant name.
  • The build is okay (tests, code climate).
  • This Pull Request mentions a related issue.

@gabrielziegler3 gabrielziegler3 self-assigned this Oct 24, 2019
@@ -16,7 +16,6 @@ import Issues from '../components/Issues/Issues.vue';
import Velocity from '../components/Sprints/Velocity.vue';
import Burndown from '../components/Sprints/Burndown.vue';
import IssuesGraphic from '../components/Issues/IssuesGraphic.vue';
import Grade from '../components/Projects/Grade.vue';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire module can be removed, since GPA has been deprecated in CC.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right? @MatheusRich

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Maybe later we add something else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also remove this file then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants