fix: SQLCipher dylib location on macOS builds #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nico-famedly
approved these changes
Aug 19, 2024
TheOneWithTheBraid
had a problem deploying
to
review
GitHub Actions
Failure
|
@nico-famedly CI fails but on a completely unrelated test, could you have a look at it ? |
|
@TheOneWithTheBraid, CI failures are unrelated:
|
nico-famedly
force-pushed
the
braid/macos-dylib
branch
from
cf01143
to
8581bc9
Compare
nico-famedly
force-pushed
the
braid/macos-dylib
branch
2 times, most recently
from
193857f
to
1887328
Compare
Signed-off-by: The one with the braid <[email protected]>
nico-famedly
force-pushed
the
braid/macos-dylib
branch
from
1887328
to
23704f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess no one ever noticed, but obviously the path of the SQLCipher build on macOS is relative to the build app on macOS. I double checked in both release and debug mode, this is the correct path for the SQLCipher dylib on macOS. The
Currentin the path defines it automatically chooses the matching one whether on aarch64 or amd64.