feat: BREAKING CHANGE add equality, hashcode and toString helper overrides to autogenerated code #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rides to autogenerated code
nico-famedly
reviewed
Oct 2, 2024
| bool operator ==(Object other) => | ||
| other is GenerateLoginTokenResponse && | ||
| other.expiresInMs == expiresInMs && | ||
| other.loginToken == loginToken; |
There was a problem hiding this comment.
This should probably not be in the logs by default?
| bool operator ==(Object other) => | ||
| other is ThreePidCredentials && | ||
| other.clientSecret == clientSecret && | ||
| other.idAccessToken == idAccessToken && |
There was a problem hiding this comment.
Should we really log this via toString by default?
| @override | ||
| bool operator ==(Object other) => | ||
| other is LoginResponse && | ||
| other.accessToken == accessToken && |
There was a problem hiding this comment.
We probably shouldn't log this via toString by default either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autogen script change: famedly/dart_openapi_codegen#50