feat: Add gossip and eviction to the mempool #200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
commented
Jan 8, 2025
FrederikBolding
commented
Jan 8, 2025
sanjayprabhu
reviewed
Jan 9, 2025
FrederikBolding
force-pushed
the
fb/mempool
branch
from
9945334 to
84c2000
Compare
FrederikBolding
changed the title
FrederikBolding
commented
Jan 10, 2025
|
|
||
| pub fn mempool_key(&self) -> MempoolKey { | ||
| if let Some(data) = &self.data { | ||
| return MempoolKey::new(data.timestamp as u64, self.hex_hash()); |
There was a problem hiding this comment.
I think this function should live inside the mempool. I would add a trait in the mempool for this, and implement the trait for the structs in there. Rest of the code doesn't have to care about this.
| @@ -287,6 +313,15 @@ impl SnapchainGossip { | |||
| let encoded_message = gossip_message.encode_to_vec(); | |||
| self.publish(encoded_message); | |||
| }, | |||
| Some(GossipEvent::BroadcastMempoolMessage(message)) => { | |||
| debug!("Broadcasting mempool message"); | |||
There was a problem hiding this comment.
Let's remove the debug logs
| @@ -149,6 +170,43 @@ impl Mempool { | |||
| return true; | |||
| } | |||
|
|
|||
| async fn insert(&mut self, message: MempoolMessage) { | |||
There was a problem hiding this comment.
Let's emit some stats here, number of inserts tagged by success/failure and message type, and a guage for the current size of the mempool by shard.
| Some(messages) => { | ||
| messages.insert(MempoolKey { inserted_at: Instant::now()}, message.clone()); | ||
| for system_message in transaction.system_messages { | ||
| mempool.remove(&system_message.mempool_key()); |
There was a problem hiding this comment.
We should record the same stats as above when removing from the mempool as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic implementation of the gossipped mempool described in #180.
Opening in draft as I am looking for feedback on the direction before proceeding.