add duplicate message validation to mempool #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjayprabhu
reviewed
Jan 8, 2025
| Some(stores) => { | ||
| // TODO(aditi): The engine reloads its ref to the trie on commit but we maintain a separate ref to the trie here. | ||
| stores.trie.reload(&stores.db).unwrap(); | ||
| match stores.trie.exists( |
There was a problem hiding this comment.
Ah ok, yeah, this is going to be an issue. We shouldn't let this leak out of the trie. Maybe one approach is to make the trie non clonable, and the have a readonly trie that always reads from the db isntead of storing anything in memory.
But at a higher level, we shouldn't use the trie for the duplicate check, it would be too slow. Read from the db directly and we can have a separate caching layer here if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw away messages that already exist in the trie in the mempool before forwarding to the engine.