Fix: Solve for Issue 189 - RPCs in rpc.proto and server.rs for #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #189
Description
This pull request addresses the implementation of the missing
GetCastsByParent
RPC and other relatedGet...
RPCs in the snapchain project.The following updates were made to resolve the issue and achieve feature parity with the existing hubs:
GetCastsByParent
RPC torpc.proto
with the necessary request and response definitions.GetCastsByParent
request inserver.rs
.cast_store.rs
to properly handle the storage and retrieval of casts by their parent.Changes Made
Updated rpc.proto
GetCastsByParent
RPC definition, following the existing structure:proto
rpc GetCastsByParent(CastsByParentRequest) returns (MessagesResponse);
Updated server.rs
get_casts_by_parent
to process the request and return the appropriate response.Updated cast_store.rs
How It Solves the Issue
The changes add the missing
GetCastsByParent
RPC to the project and updatecast_store.rs
to handle the necessary data queries. This enables clients to query casts by their parent, bringing the functionality in line with other similarGet...
RPCs and ensuring completeness of the API.Checklist
GetCastsByParent
RPC torpc.proto
.GetCastsByParent
RPC logic inserver.rs
.cast_store.rs
to handle casts by parent.