use the message store for mempool validation #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditiharini
changed the title
| let set_postfix = type_to_set_postfix(message_data.r#type()); | ||
| let primary_key = | ||
| make_message_primary_key(fid, set_postfix as u8, Some(&ts_hash)); | ||
| let existing_message = get_message_by_key( |
There was a problem hiding this comment.
This is too low level for the mempool. It should just be doing stores.message_exists(&message);
| }, | ||
| MempoolMessage::ValidatorMessage(message) => { | ||
| if let Some(onchain_event) = &message.on_chain_event { | ||
| match stores.onchain_event_store.exists(&onchain_event) { |
There was a problem hiding this comment.
I would push this into stores.onchain_event_exists as well.
| match &fname_transfer.proof { | ||
| None => return false, | ||
| Some(proof) => { | ||
| let username_proof = UserDataStore::get_username_proof( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using the trie to the account store for the duplicate message check in the mempool.