-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Properly support inheritance of Relationship attributes #886
Open
earshinov
wants to merge
4
commits into
fastapi:main
Choose a base branch
from
earshinov:relationship-inheritance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earshinov
force-pushed
the
relationship-inheritance
branch
6 times, most recently
from
April 8, 2024 17:50
6d05a4b
to
8f30325
Compare
earshinov
changed the title
WIP: ✨Properly support inheritance of Relationship attributes
✨Properly support inheritance of Relationship attributes
Apr 8, 2024
8 tasks
earshinov
force-pushed
the
relationship-inheritance
branch
7 times, most recently
from
April 12, 2024 12:12
2200fc5
to
f95b739
Compare
earshinov
commented
Apr 12, 2024
@@ -68,7 +68,7 @@ jobs: | |||
run: pip install --upgrade "pydantic>=1.10.0,<2.0.0" | |||
- name: Install Pydantic v2 | |||
if: matrix.pydantic-version == 'pydantic-v2' | |||
run: pip install --upgrade "pydantic>=2.0.2,<3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be rolled back before merging
…eatedUpdatedMixin used in test
earshinov
force-pushed
the
relationship-inheritance
branch
from
April 12, 2024 12:21
f95b739
to
766d08a
Compare
Csaba1205
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the test I added:
Given how the test model is defined and without the proposed fix, the test fails with:
That is, a
Relationship
defined in the base model is not recognized as a relationship in the child.