Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly parse userinfo in uri #101

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: properly parse userinfo in uri #101

merged 1 commit into from
Sep 26, 2024

Conversation

zekth
Copy link
Member

@zekth zekth commented Sep 25, 2024 •
edited
Loading

Try addressing #100

Checklist

@zekth zekth changed the title test fix: properly parse userinfo in uri Sep 25, 2024
@zekth zekth marked this pull request as ready for review September 25, 2024 15:52
@zekth zekth requested a review from Uzlopak September 25, 2024 16:01
@zekth
Copy link
Member Author

zekth commented Sep 25, 2024

@Uzlopak could you please take a look? 🙏

gurgunday
gurgunday approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes lgtm

mcollina
mcollina approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zekth zekth merged commit 2ebe20a into main Sep 26, 2024
22 checks passed
@zekth zekth deleted the fix/100 branch September 26, 2024 16:19
@zekth
Copy link
Member Author

zekth commented Sep 26, 2024

@gurgunday @mcollina could you make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gurgunday gurgunday gurgunday approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zekth @mcollina @gurgunday