Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(index): merge concurrent array.push calls #97

Merged
merged 1 commit into from
Jul 22, 2024
Merged

perf(index): merge concurrent array.push calls #97

merged 1 commit into from
Jul 22, 2024

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jul 19, 2024

Add multiple values to arrays with a single push call rather than successive ones.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

CI does not look happy

@jsumners
Copy link
Member

CI does not look happy

22.5.1 doesn't exist yet.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Fdawgs
Copy link
Member Author

Fdawgs commented Jul 19, 2024

CI does not look happy

npm/cli#7666 :(

@mcollina mcollina merged commit 26cd10a into main Jul 22, 2024
24 checks passed
@jsumners jsumners deleted the perf/push branch July 22, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants