refactor: prefix unused params with underscores (#165)

fastify · Dec 30, 2024 · 9a92d5a · 9a92d5a
1 parent 63834cc
commit 9a92d5a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/lib/fastifyAwilixPlugin.js b/lib/fastifyAwilixPlugin.js
@@ -41,7 +41,7 @@ function plugin (fastify, opts, next) {
   fastify.decorate('diContainer', resolvedContainer)
   fastify.decorateRequest('diScope', null)
 
-  fastify.addHook('onRequest', (request, reply, done) => {
+  fastify.addHook('onRequest', (request, _reply, done) => {
     request.diScope = resolvedContainer.createScope()
     done()
   })
@@ -82,7 +82,7 @@ function plugin (fastify, opts, next) {
   }
 
   if (disposeOnResponse) {
-    fastify.addHook('onResponse', (request, reply, done) => {
+    fastify.addHook('onResponse', (request, _reply, done) => {
       if (request.diScope) {
         request.diScope.dispose().then(done, done)
       }

diff --git a/lib/index.test-d.ts b/lib/index.test-d.ts
@@ -50,7 +50,7 @@ const app: FastifyInstance = fastify()
 
 app.register(fastifyAwilixPlugin, {})
 
-app.addHook('onRequest', (request, reply, done) => {
+app.addHook('onRequest', (request, _reply, done) => {
   request.diScope.register({
     user: asValue({
       name: 'John Doe',

diff --git a/test/fastifyAwilixPlugin.dispose.test.js b/test/fastifyAwilixPlugin.dispose.test.js
@@ -58,7 +58,7 @@ describe('fastifyAwilixPlugin', () => {
 
   variations.forEach((variation) => {
     describe(variation.injectionMode, () => {
-      const endpoint = async (req, res) => {
+      const endpoint = async (_req, res) => {
         const userRepository = app.diContainer.resolve('userRepository')
         storedUserRepository = userRepository
 
@@ -140,7 +140,7 @@ describe('fastifyAwilixPlugin', () => {
 
         it('do not attempt to dispose request scope if response was returned before it was even created', async () => {
           app = fastify({ logger: true })
-          await app.addHook('onRequest', (request, reply) => {
+          await app.addHook('onRequest', (_request, reply) => {
             return reply.send('OK')
           })
 
@@ -157,7 +157,7 @@ describe('fastifyAwilixPlugin', () => {
           })
 
           let storedError = null
-          app.setErrorHandler((err, request, reply) => {
+          app.setErrorHandler((err, _request, reply) => {
             storedError = err
             return reply.send('Error')
           })
@@ -190,7 +190,7 @@ describe('fastifyAwilixPlugin', () => {
               dispose: (service) => service.dispose()
             })
           })
-          app.addHook('onRequest', (request, reply, done) => {
+          app.addHook('onRequest', (request, _reply, done) => {
             request.diScope.register({
               userRepositoryScoped: asClass(UserRepository, {
                 lifetime: Lifetime.SCOPED,
@@ -229,7 +229,7 @@ describe('fastifyAwilixPlugin', () => {
               dispose: (service) => service.dispose()
             })
           })
-          app.addHook('onRequest', (request, reply, done) => {
+          app.addHook('onRequest', (request, _reply, done) => {
             request.diScope.register({
               userRepositoryScoped: asClass(UserRepository, {
                 lifetime: Lifetime.SCOPED,