chore: drop eslint #148
Merged
chore: drop eslint #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Aug 10, 2024
| "fastify": "^4.26.2", | ||
| "prettier": "^3.2.5", | ||
| "snazzy": "^9.0.0", | ||
| "standard": "^17.1.0", |
There was a problem hiding this comment.
One dep to rule them all: when we have these silly trouble due a breaking change, it is always a pain if we use one different library for every repo. Pain means time that nobody wants to invest in these tasks.
This pr is no brainier because we run these deps on every other fastify repo. We know them, we trust them.
Evaluating something else is something that we need to do (standard is no more used in the main repo), but it is a different task imho
kibertoad
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblock #146
adding our "standard" linters