-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use generic on userinfo #263
base: master
Are you sure you want to change the base?
Conversation
hi guys, any comments here? |
Yeah, I checked it locally and it strange, that the Generic without default type is by default Object. Is this something new in typescript? I expected that we would get some type error, because we dont set the type in the tsd tests? Please add a tsd test like this in index.test-d.ts at about line 286
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Eomm
PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the follow up on this! |
@Joabesv I'm so sorry, but these conflicts now. Can you rebase/fix them? |
hi there, just adding to avoid an
as Type
, and generic is compatible withObject
so it shouldn't break anything (as it already didn't)Checklist
npm run test
andnpm run benchmark
and the Code of conduct