Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use generic on userinfo #263

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Joabesv
Copy link

@Joabesv Joabesv commented Jun 28, 2024

hi there, just adding to avoid an as Type, and generic is compatible with Object so it shouldn't break anything (as it already didn't)

Checklist

types/index.d.ts Outdated Show resolved Hide resolved
@Eomm Eomm requested a review from Uzlopak September 22, 2024 09:26
@Joabesv
Copy link
Author

Joabesv commented Nov 1, 2024

hi guys, any comments here?

@Uzlopak
Copy link
Contributor

Uzlopak commented Nov 18, 2024

@Joabesv

Yeah, I checked it locally and it strange, that the Generic without default type is by default Object. Is this something new in typescript? I expected that we would get some type error, because we dont set the type in the tsd tests?

Please add a tsd test like this in index.test-d.ts at about line 286

expectType<{bla: string}>(await server.testOAuthName.userinfo<{bla: string}>(token.token.access_token));

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm
PTAL

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Joabesv
Copy link
Author

Joabesv commented Nov 22, 2024

Thanks for the follow up on this!

@mcollina
Copy link
Member

@Joabesv I'm so sorry, but these conflicts now. Can you rebase/fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants