Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to node test runner #495

Merged
merged 93 commits into from
Jan 10, 2025
Merged

Migration to node test runner #495

merged 93 commits into from
Jan 10, 2025

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Jan 4, 2025

Checklist

  • run npm run test and npm run benchmark

  • tests and/or benchmarks are included

  • documentation is changed or added

  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

  • Migrated to node test runner

  • Removed simple-get in favour of fetch

ilteoood added 30 commits January 1, 2025 23:26
@ilteoood
chore: remove tap
a5a9a0f
@ilteoood
chore: content type promises
2e52f58
@ilteoood
chore: removed simple get
b8578c3
@ilteoood
chore: listen as promise
b76489c
@ilteoood
chore: prefixAvoidTrailingSlash
04b4905
@ilteoood
fix: register /static
d5f8d38
@ilteoood
feat: static
72468c1
@ilteoood
feat: static static2
edeece6
@ilteoood
chore: constraints
b4e1ca1
@ilteoood
chore: payload path
80f65fb
@ilteoood
chore: error handler
d34908c
@ilteoood
fix: not found
27fa33d
@ilteoood
chore: not foundhandler
af454c2
@ilteoood
chore: serving disabled
073effc
@ilteoood
chore: sendFile
be4b33b
@ilteoood
chore: sendFile disabled
1224311
@ilteoood
chore: allowedPath
dd9751f
@ilteoood
chore: allowed path request
30cff99
@ilteoood
chore: download
d66ff12
@ilteoood
chore: sendFile
a50045f
@ilteoood
chore: removed duplicated test
c7cd358
@ilteoood
chore: download disabled
2dccee5
@ilteoood
chore: tests
4544b3b
@ilteoood
chore: send options
11eee29
@ilteoood
chore: setHeaders option
e8e5dc8
@ilteoood
chore: maxAge
41a153a
@ilteoood
chore: errors
ae8c5fc
@ilteoood
chore: register no prefix
0059a7c
@ilteoood
chore: compress
e8e0ff7
@ilteoood
chore: register static schema hide
c6660e9
@ilteoood ilteoood requested a review from dancastillo January 5, 2025 09:57
dancastillo
dancastillo reviewed Jan 5, 2025
View reviewed changes
test/static.test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/static.test.js Outdated Show resolved Hide resolved
@ilteoood @dancastillo
Update test/static.test.js
8ba0eb1 
Co-authored-by: Dan Castillo <[email protected]>
Signed-off-by: Matteo Pietro Dazzi <[email protected]>
@ilteoood ilteoood requested a review from dancastillo January 5, 2025 15:39
This was referenced Jan 6, 2025
Merged
Merged
simoneb
simoneb reviewed Jan 8, 2025
View reviewed changes
package.json Outdated Show resolved Hide resolved
dancastillo
dancastillo reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would just updated the coverage check and add --check-coverage --lines 100 to test:unit and coverage to ensure it maintains coverage

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ilteoood and others added 2 commits January 9, 2025 19:17
@ilteoood @dancastillo
Update package.json
d1ec8d7 
Co-authored-by: Dan Castillo <[email protected]>
Signed-off-by: Matteo Pietro Dazzi <[email protected]>
@ilteoood @dancastillo
Update package.json
872c7f9 
Co-authored-by: Dan Castillo <[email protected]>
Signed-off-by: Matteo Pietro Dazzi <[email protected]>
dancastillo
dancastillo approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fdawgs
Fdawgs requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c8 has gone missing from the dev dependencies, but is used in the coverage script.

@ilteoood ilteoood requested a review from Fdawgs January 10, 2025 11:55
@Fdawgs Fdawgs merged commit 6d1dcf8 into fastify:master Jan 10, 2025
8 of 11 checks passed
@Eomm Eomm mentioned this pull request Jan 18, 2025
Merged
4 tasks
@ilteoood ilteoood mentioned this pull request Feb 7, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancastillo dancastillo dancastillo approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

@simoneb simoneb Awaiting requested review from simoneb

@mcollina mcollina Awaiting requested review from mcollina

@gurgunday gurgunday Awaiting requested review from gurgunday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilteoood @simoneb @mcollina @dancastillo @Fdawgs @gurgunday