Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb through reading the FASTLY_KEY env variable to compute modules #377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Plumb through reading the FASTLY_KEY env variable to compute modules #377

wants to merge 2 commits into from

Conversation

computermouth
Copy link
Contributor

This is mostly for some internal testing at the moment, but potentially of use to end users who want to utilize fastly services or features which aren't included in the SDK yet. Also allows for local testing against production services.

@elliottt
Copy link
Contributor

elliottt commented Jun 3, 2024

Looks like tests are failing the formatting step, could you run cargo fmt and commit the results?

elliottt
elliottt approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this seems reasonable, and is a good way to start distinguishing between components that target the viceroy environment, vs the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottt elliottt elliottt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@computermouth @elliottt