Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Add support for Observability custom dashboards. #905

Merged
merged 16 commits into from
Jan 14, 2025

Conversation

tlindsay
Copy link
Member

@tlindsay tlindsay commented Dec 6, 2024

Redo of #902, which was merged without an approval from DevTools team

Jira:CDTOOL-816

Description: Adds support for Fastly Custom Observability Dashboards CRUD operations

@tlindsay tlindsay requested a review from kpfleming December 6, 2024 18:04
@tlindsay tlindsay force-pushed the pl/custom-dashboards branch from 2f72446 to 3a95d34 Compare December 6, 2024 19:23
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes, otherwise this looks fine. Can you confirm that the acceptance tests pass? I don't think I'll be able to run them this week.

examples/resources/custom_dashboard_basic_usage.tf Outdated Show resolved Hide resolved
examples/resources/custom_dashboard_basic_usage.tf Outdated Show resolved Hide resolved
examples/resources/custom_dashboard_basic_usage.tf Outdated Show resolved Hide resolved
templates/resources/custom_dashboard.md.tmpl Outdated Show resolved Hide resolved
templates/resources/custom_dashboard.md.tmpl Outdated Show resolved Hide resolved
@tlindsay tlindsay requested a review from kpfleming January 13, 2025 19:44
@kpfleming kpfleming changed the title Pl/custom dashboards feat(dashboard): Add support for Observability custom dashboards. Jan 13, 2025
@kpfleming kpfleming merged commit edfc89f into main Jan 14, 2025
11 checks passed
@kpfleming kpfleming deleted the pl/custom-dashboards branch January 14, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants