Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put an error message for deleting wo dictionaries #918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skygus
Copy link

@skygus skygus commented Jan 30, 2025

I ran into an issue trying to delete a write-only dictionary, and it was difficult to understand what was happening. It returns an error: Bad request: Not allowed to read contents of write_only dictionary, which doesn't make any sense, since I'm trying to delete it.

I see there's a check for deleting a dictionary which lists the contents, but this won't work for write only dictionaries, so we should have a check to see if it's a write only dictionary first, and return an error to say you should have the force_destroy flag.

TBH, I didn't understand how to add a test for this, so this PR is basically informational.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant