Feat/ftd main package #2060
Closed
Feat/ftd main package #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARN: the `ftd.main-package` does not work yet. It's stored in the `global` map in js output and it's not getting resolved when used in an ftd file. This should be key on `ftd` object itself. - `ftd.main-package`: A string variable that stores the name of the packaeg. This is useful to determine if a package is mounted in another package or if it's running standalone. - Refactor: Create `HostBuiltins` type and use it instead of Array of fixed sized type everywhere. This makes it easy to add new builtins
This allows to use the following in ftd code: ```ftd -- ftd.text: $ftd.main-package ```
amitu
reviewed
Jan 31, 2025
| /// | ||
| /// Useful to determine if the package is run standalone or as a dependency: | ||
| #[inline] | ||
| pub fn main_package(pkg: &fastn_core::Package) -> (String, fastn_resolved::Definition) { |
There was a problem hiding this comment.
This should also take fastn_core::Config as argument, for the same reason I discussed yesterday.
There was a problem hiding this comment.
Also maybe you can make impl Config { fn main_package() {} } so it shows up in code completion etc, which has better discovery than scattered utility methods.
|
In the task list add docs as well. |
siddhantk232
force-pushed
the
feat/ftd_main_package
branch
from
8ecb8ce to
5806e7a
Compare
|
Closing in favor of #2061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
ftd.main-packagevariableappparam toftd.app-pathftd.app-pathftd.main-package