Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore schema for all reply_ subtypes #1058

Merged
merged 13 commits into from
Feb 19, 2025

Conversation

khyatimahendru
Copy link
Collaborator

No description provided.

@khyatimahendru khyatimahendru marked this pull request as draft January 16, 2025 14:08
@khyatimahendru khyatimahendru marked this pull request as ready for review January 27, 2025 11:15
@khyatimahendru khyatimahendru requested a review from grafnu January 27, 2025 15:47
@@ -0,0 +1,20 @@
{
"gateway" : { },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm -- this doesn't look like the body of a reply message, it looks like a model message of some kind. Where did you get it from? Shouldn't really matter since the filter is all on the subType, but probably a good idea to have it be representative!

tests/traces/simple/expected/devices/GAT-123/reply.out Outdated Show resolved Hide resolved
@khyatimahendru khyatimahendru merged commit c438a89 into faucetsdn:master Feb 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants