Added testing functionality #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix small bug with output if metadata option is used Improve an error message Let output file name reflect its format Update installation instructions to assist with errors
Adapt tests to also work on windows
fbaumdicker
reviewed
Jan 23, 2025
| @@ -1,5 +1,5 @@ | |||
| Gene,Non-unique Gene name,Annotation,No. isolates,No. sequences,Avg sequences per isolate,Genome Fragment,Order within Fragment,Accessory Fragment,Accessory Order with Fragment,QC,Min group size nuc,Max group size nuc,Avg group size nuc,s1,s2,s3,s4,s5 | |||
| a,,,,,,,,,,,,,,x,,x,x, | |||
| a,abc,hypothetical protein,,,,,,,,,,,,x,,x,x, | |||
There was a problem hiding this comment.
can we use something else than "abc" for the gene name, as this might be confusing with the genes a, b, c. How about "gene_a"?
|
Besides this one minor naming, this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow easier further developments (like addressing #4 ). The tests work on ubuntu and windows.
Also, I found a small bug during testing, the fix is included in this pull request.
I renamed one of the output files' ending to reflect its format. The readme is edited correspondingly.
Lastly, I added some information regarding errors during installation to the readme.