Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few csv fixes #398

Merged
merged 3 commits into from
Feb 28, 2017
Merged

A few csv fixes #398

merged 3 commits into from
Feb 28, 2017

Conversation

harrisj
Copy link
Contributor

@harrisj harrisj commented Feb 24, 2017

Fixes 18F/crime-data-explorer#312

This does a few things:

  1. Add support to pass an output=csv argument to the geo/states/<state_id>/participation endpoint
  2. The /agencies/participation endpoint also accepts a year=1991 or ranged year=1991-2001 arguments

Jacob Harris added 3 commits February 24, 2017 15:22
Fix CSV generation to take a filename argument
0e4568e
StateParticipation endpoint now can output CSV
492324a 
I used this as an opportunity to refactor _get to have a separate
method it calls for rendering the output
Hack agencies_participation to take a ranged year argument
c2db689 
Both ?year=1991 and ?year=1991-2001 will work
@harrisj harrisj requested a review from cacraig February 24, 2017 22:44
@jeremiak
Copy link
Contributor

Awesome, I subscribed so once this gets merged I'll take a stab at the explorer work

@cacraig
Copy link
Contributor

cacraig commented Feb 28, 2017

GTG!

@cacraig cacraig merged commit 9ca5172 into master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacraig cacraig Awaiting requested review from cacraig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrisj @jeremiak @cacraig