Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap network improvements #277

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Bootstrap network improvements #277

wants to merge 1 commit into from

Conversation

fboucquez
Copy link
Owner

@fboucquez fboucquez commented Jul 6, 2021 •
edited
Loading

This PR is the bootstrap changes required before the lerna split and symbol-network app.

There are several improvements.

  • custom preset cached on target
  • Renamed bootstrap preset for dualCurrency. Added singleCurrency preset.
  • Removed unused genesis state files after generating
  • Nemesis seed is shared across the different nodes avoiding duplicated files.
  • Improved unit testing. Heavily tested using expected target zip with lots of network/assembly/customPreset combinations.

Fixes #60
Fixes #245
Fixes #80

@fboucquez fboucquez mentioned this pull request Jul 6, 2021
Merged
@fboucquez fboucquez force-pushed the networkPresetFile branch 8 times, most recently from 8e29cf1 to 7be59ce Compare July 6, 2021 17:30
@fboucquez fboucquez changed the title Private Network Improvements Local Network Improvements Jul 21, 2021
@fboucquez fboucquez changed the title Local Network Improvements Bootstrap network improvements Jul 22, 2021
@fboucquez fboucquez force-pushed the networkPresetFile branch 2 times, most recently from 696e3e2 to f97642b Compare July 23, 2021 12:40
@fboucquez fboucquez requested a review from yilmazbahadir July 23, 2021 12:50
@fboucquez fboucquez force-pushed the networkPresetFile branch 4 times, most recently from 801377f to a310699 Compare July 23, 2021 17:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@fboucquez fboucquez force-pushed the networkPresetFile branch 5 times, most recently from 13c1ea2 to 06e78ba Compare October 18, 2021 22:21
@fboucquez fboucquez force-pushed the networkPresetFile branch 3 times, most recently from 11f7e8f to 8f6486e Compare November 25, 2021 00:41
@fboucquez fboucquez force-pushed the networkPresetFile branch 5 times, most recently from 30c989c to 788c803 Compare November 26, 2021 13:56
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gimre-xymcity
Copy link

Why there are so many changes packed in a single review?

@gimre-xymcity
Copy link

what is the status of this?

@fboucquez
Copy link
Owner Author

fboucquez commented Dec 9, 2021 •
edited
Loading

what is the status of this?

I'm a 2-3 of PRs away before dropping this branch. Once we have the other PRs merged, the first version of symbol-network would be able to use the official symbol-bootstrap lib.

https://github.com/fboucquez/symbol-network
https://hackmd.io/Ak7Sl1A6SkKV7ga0QW00LA

Eventually, if you are keen, symbol-network could be a submodule of symbol-bootstrap, similar to how this branch looks https://github.com/symbol/symbol-bootstrap/tree/multimodule (lerna multimodule monorepo)

@fboucquez fboucquez force-pushed the dev branch 11 times, most recently from 9627f1a to 347034c Compare January 14, 2022 14:59
@fboucquez
Improved configuration testing
b5de0d2 
singleCurrency and dualCurrency presets.
nemesis seed is shared across the different nodes avoiding duplicated files.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yilmazbahadir yilmazbahadir Awaiting requested review from yilmazbahadir

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fboucquez @gimre-xymcity