Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade richie to v2.29.2 #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tiago-Salles
Copy link

@Tiago-Salles Tiago-Salles commented Sep 27, 2024

This PR updates richie to v2.29.2.

The considerable change is related with the git+https://github.com/openfun/[email protected]#egg=django-cms package installation that was removed from the docker file and inserted to base.txt as the openfun commit.

This PR is related to: Upgrade richie to v2.29.1 on nau-richie-site-factory #261

@Tiago-Salles Tiago-Salles force-pushed the Tiago-Salles/261/upgrade-richie branch 2 times, most recently from 9de19fd to dbc5836 Compare September 27, 2024 14:53
@Tiago-Salles Tiago-Salles requested review from sandroscosta and igobranco and removed request for sandroscosta September 27, 2024 14:55
@Tiago-Salles Tiago-Salles changed the title Upgrade richie to v2.29.1 Upgrade richie to v2.29.2 Sep 27, 2024
@sandroscosta sandroscosta force-pushed the Tiago-Salles/261/upgrade-richie branch from 8b505c2 to 396bc34 Compare October 2, 2024 19:32
@sandroscosta
Copy link
Contributor

@igobranco and @Tiago-Salles please test this again. It's working now but I need further confirmation.

@igobranco
Copy link
Member

@sandroscosta and @Tiago-Salles I confirm that it is working fine now!

@igobranco
Copy link
Member

Nevertheless, I think we should remove the bump of new release on this branch.
@Tiago-Salles please create a new PR with your upgrade. Then cherry pick @sandroscosta fix on top.

@Tiago-Salles
Copy link
Author

Tiago-Salles commented Oct 2, 2024

@sandroscosta and @igobranco I can confirm as well that it works to me, @sandroscosta I will rebase this branch using your commit as the main one.

Changelog available at:
https://github.com/openfun/richie/releases/tag/v2.29.2

🚨(docker) removed django-cms dependency installation from Dockerfile

🩹(yarn) adjusted missing .lock file
@Tiago-Salles Tiago-Salles force-pushed the Tiago-Salles/261/upgrade-richie branch from 396bc34 to e7ae4a6 Compare October 3, 2024 10:11
@igobranco
Copy link
Member

@Tiago-Salles add a line to the CHANGELOG.md.

Like:

⬆️(nau) upgrade richie to v2.....

Upgrade eslint version to fix th dependency mismatch with Richie
Fix `base.txt` requirements.

⬆️(nau) upgrade richie to v2.29.2
@Tiago-Salles Tiago-Salles force-pushed the Tiago-Salles/261/upgrade-richie branch from 801b864 to 4b01488 Compare October 7, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants