Relax the compose modifier key check.

This allows compose key to be handled by pinyin/table if compose sequence has shift.
fcitx · May 27, 2024 · 3e14430 · 3e14430
1 parent 5dd323b
commit 3e14430
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/im/pinyin/pinyin.cpp b/im/pinyin/pinyin.cpp
@@ -1813,7 +1813,9 @@ bool PinyinEngine::handlePunc(KeyEvent &event) {
 bool PinyinEngine::handleCompose(KeyEvent &event) {
     auto *inputContext = event.inputContext();
     auto *state = inputContext->propertyFor(&factory_);
-    if (event.key().hasModifier() || state->mode_ != PinyinMode::Normal) {
+    if (event.key().states().testAny(
+            KeyStates{KeyState::Ctrl, KeyState::Super}) ||
+        state->mode_ != PinyinMode::Normal) {
         return false;
     }
     auto candidateList = inputContext->inputPanel().candidateList();

diff --git a/im/table/state.cpp b/im/table/state.cpp
@@ -866,7 +866,8 @@ void TableState::keyEvent(const InputMethodEntry &entry, KeyEvent &event) {
     }
 
     if ((mode_ == TableMode::Normal || mode_ == TableMode::Pinyin) &&
-        !event.key().hasModifier()) {
+        !event.key().states().testAny(
+            KeyStates{KeyState::Ctrl, KeyState::Super})) {
         auto compose = engine_->instance()->processComposeString(
             inputContext, event.key().sym());
         if (!compose) {