Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow XIM XNArea for client preedit area in OnTheSpot mode. #1163

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

xorgy
Copy link
Contributor

@xorgy xorgy commented Oct 28, 2024

No description provided.

@xorgy xorgy mentioned this pull request Oct 28, 2024
@xorgy xorgy force-pushed the on-the-spot-xnarea branch from 681be7c to 28ab92f Compare October 28, 2024 22:32
@xorgy
Copy link
Contributor Author

xorgy commented Oct 28, 2024

See #1162 for discussion and rationale.

@xorgy xorgy force-pushed the on-the-spot-xnarea branch 2 times, most recently from ea17374 to 6c4dc4c Compare October 28, 2024 22:35
@xorgy xorgy force-pushed the on-the-spot-xnarea branch from 6c4dc4c to cd583ac Compare January 13, 2025 14:27
@xorgy xorgy marked this pull request as ready for review January 13, 2025 14:27
@xorgy
Copy link
Contributor Author

xorgy commented Jan 13, 2025

@wengxt clang-format check is failing on files from master in CI, but runs fine locally. Not sure what to do with that.

@wengxt wengxt force-pushed the on-the-spot-xnarea branch from cd583ac to b77fb93 Compare January 13, 2025 22:25
@wengxt
Copy link
Member

wengxt commented Jan 13, 2025

@wengxt clang-format check is failing on files from master in CI, but runs fine locally. Not sure what to do with that.

CI uses clang 19 and there seems to be some regression on format. I tried to workaround it and now it should be fine.

@wengxt wengxt merged commit 7c21217 into fcitx:master Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants