Fix MozcDirectClient::Call

output should be assigned after EvalCommand.
fcitx · Dec 28, 2024 · 8709802 · 8709802
1 parent 8fc360d
commit 8709802
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/unix/fcitx5/mozc_direct_client.cc b/src/unix/fcitx5/mozc_direct_client.cc
@@ -219,8 +219,11 @@ bool MozcDirectClient::Call(const mozc::commands::Input &input,
                             mozc::commands::Output *output) {
   mozc::commands::Command command;
   *command.mutable_input() = input;
+  if (!GetSessionHandler()->EvalCommand(&command)) {
+    return false;
+  }
   *output = command.output();
-  return GetSessionHandler()->EvalCommand(&command);
+  return true;
 }
 
 void MozcDirectClient::InitInput(mozc::commands::Input *input) const {