Adding config reload capacity via SIGHUP - #1444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Thanks for the project
I created a simple pull request which adds SIGHUP reload capacity to the server enabling it to reload the config without needing to restart the ftpserver process. Sice you already had SIGTERM i just extended it :)
I've experimented with many other config reloads but this is the easiest one to add and is supported by systemd and other linux/unix systems (https://en.wikipedia.org/wiki/SIGHUP#Modern_usage)
I've tested it and if there's an error, the previous config just stays in memory and the current one is rejected.
Alternatives: file HASH/reload version could also be useful, fsnotify adds too many extra dependencies.