Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename Helm Operator #4569

Merged
merged 1 commit into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
needs: [get-version, publish-python-sdk]
strategy:
matrix:
component: [feature-server, feature-server-java, feature-transformation-server, feast-operator]
component: [feature-server, feature-server-java, feature-transformation-server, feast-helm-operator]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: feastdev
Expand Down
2 changes: 1 addition & 1 deletion .releaserc.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ module.exports = {
"CHANGELOG.md",
"java/pom.xml",
"infra/charts/**/*.*",
"infra/feast-operator/**/*",
"infra/feast-helm-operator/**/*",
"ui/package.json",
"sdk/python/feast/ui/package.json",
"sdk/python/feast/ui/yarn.lock"
Expand Down
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -430,15 +430,15 @@ build-feature-server-java-docker:
-t $(REGISTRY)/feature-server-java:$(VERSION) \
-f java/infra/docker/feature-server/Dockerfile --load .

push-feast-operator-docker:
cd infra/feast-operator && \
IMAGE_TAG_BASE=$(REGISTRY)/feast-operator \
push-feast-helm-operator-docker:
cd infra/feast-helm-operator && \
IMAGE_TAG_BASE=$(REGISTRY)/feast-helm-operator \
VERSION=$(VERSION) \
$(MAKE) docker-push

build-feast-operator-docker:
cd infra/feast-operator && \
IMAGE_TAG_BASE=$(REGISTRY)/feast-operator \
build-feast-helm-operator-docker:
cd infra/feast-helm-operator && \
IMAGE_TAG_BASE=$(REGISTRY)/feast-helm-operator \
VERSION=$(VERSION) \
$(MAKE) docker-build

Expand Down
2 changes: 1 addition & 1 deletion docs/how-to-guides/running-feast-in-production.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ helm install feast-release feast-charts/feast-feature-server \

This will deploy a single service. The service must have read access to the registry file on cloud storage and to the online store (e.g. via [podAnnotations](https://kubernetes-on-aws.readthedocs.io/en/latest/user-guide/iam-roles.html)). It will keep a copy of the registry in their memory and periodically refresh it, so expect some delays in update propagation in exchange for better performance.

> Alternatively, deploy the same helm chart with a [Kubernetes Operator](/infra/feast-operator).
> Alternatively, deploy the same helm chart with a [Kubernetes Operator](/infra/feast-helm-operator).

## 5. Using environment variables in your yaml configuration

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ BUNDLE_METADATA_OPTS ?= $(BUNDLE_CHANNELS) $(BUNDLE_DEFAULT_CHANNEL)
# This variable is used to construct full image tags for bundle and catalog images.
#
# For example, running 'make bundle-build bundle-push catalog-build catalog-push' will build and push both
# feastdev/feast-operator-bundle:$VERSION and feastdev/feast-operator-catalog:$VERSION.
IMAGE_TAG_BASE ?= feastdev/feast-operator
# feastdev/feast-helm-operator-bundle:$VERSION and feastdev/feast-helm-operator-catalog:$VERSION.
IMAGE_TAG_BASE ?= feastdev/feast-helm-operator

# BUNDLE_IMG defines the image:tag used for the bundle.
# You can use it as an arg. (E.g make bundle-build BUNDLE_IMG=<some-registry>/<project-name-bundle>:<tag>)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ layout:
plugins:
manifests.sdk.operatorframework.io/v2: {}
scorecard.sdk.operatorframework.io/v2: {}
projectName: feast-operator
projectName: feast-helm-operator
resources:
- api:
crdVersion: v1
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Adds namespace to all resources.
namespace: feast-operator-system
namespace: feast-helm-operator-system

# Value of this field is prepended to the
# names of all resources, e.g. a deployment named
# "wordpress" becomes "alices-wordpress".
# Note that it should also match with the prefix (text before '-') of the namespace
# field above.
namePrefix: feast-operator-
namePrefix: feast-helm-operator-

# Labels to add to all resources and selectors.
#labels:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
images:
- name: controller
newName: feastdev/feast-operator
newName: feastdev/feast-helm-operator
newTag: 0.40.0
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
app.kubernetes.io/name: namespace
app.kubernetes.io/instance: system
app.kubernetes.io/component: manager
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: system
---
Expand All @@ -21,8 +21,8 @@ metadata:
app.kubernetes.io/name: deployment
app.kubernetes.io/instance: controller-manager
app.kubernetes.io/component: manager
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
spec:
selector:
Expand Down Expand Up @@ -68,7 +68,7 @@ spec:
containers:
- args:
- --leader-elect
- --leader-election-id=feast-operator
- --leader-election-id=feast-helm-operator
image: controller:latest
name: manager
securityContext:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# These resources constitute the fully configured set of manifests
# used to generate the 'manifests/' directory in a bundle.
resources:
- bases/feast-operator.clusterserviceversion.yaml
- bases/feast-helm-operator.clusterserviceversion.yaml
- ../default
- ../samples
- ../scorecard
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
app.kubernetes.io/name: clusterrole
app.kubernetes.io/instance: feastfeatureserver-editor-role
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: feastfeatureserver-editor-role
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/name: clusterrole
app.kubernetes.io/instance: feastfeatureserver-editor-role
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: feastfeatureserver-editor-rolebinding
roleRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
app.kubernetes.io/name: role
app.kubernetes.io/instance: leader-election-role
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: leader-election-role
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/name: rolebinding
app.kubernetes.io/instance: leader-election-rolebinding
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: leader-election-rolebinding
roleRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/name: clusterrole
app.kubernetes.io/instance: manager-role
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: manager-role
rules:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/name: clusterrolebinding
app.kubernetes.io/instance: manager-rolebinding
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: manager-rolebinding
roleRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
app.kubernetes.io/name: serviceaccount
app.kubernetes.io/instance: controller-manager-sa
app.kubernetes.io/component: rbac
app.kubernetes.io/created-by: feast-operator
app.kubernetes.io/part-of: feast-operator
app.kubernetes.io/created-by: feast-helm-operator
app.kubernetes.io/part-of: feast-helm-operator
app.kubernetes.io/managed-by: kustomize
name: controller-manager
namespace: system
4 changes: 2 additions & 2 deletions infra/scripts/release/files_to_bump.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ infra/charts/feast/README.md 11 68 69
infra/charts/feast-feature-server/Chart.yaml 5
infra/charts/feast-feature-server/README.md 3
infra/charts/feast-feature-server/values.yaml 12
infra/feast-operator/Makefile 6
infra/feast-operator/config/manager/kustomization.yaml 8
infra/feast-helm-operator/Makefile 6
infra/feast-helm-operator/config/manager/kustomization.yaml 8
java/pom.xml 38
ui/package.json 3
Loading