Retain same manifest outputted names with Vite v6 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks lovely! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
By setting
originalFileNameonemitFilecalls, the output I produced with my Laravel MWE (https://github.com/jnoordsij/laravel-laravel/compare/webfont-dl-mwe) is identical with Vite v5 and Vite v6. This is inspired by vitejs/vite#18820, where Vite "internally" does the same thing to mark the asset as "implicit entrypoint".It seems somewhat odd when comparing to the notes Rollup docs provide on this (see https://rollupjs.org/plugin-development/#this-emitfile), but doesn't seem harmful from what I can see.