Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text refactoring #390

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Text refactoring #390

wants to merge 2 commits into from

Conversation

Defman
Copy link
Member

@Defman Defman commented Mar 8, 2021

Refactors the text API and adds ANSI terminal support.

There is still a few things missing:

  • Serialization and Deserialization, not quite sure how it should be handled, maybe an IR enum.
  • Allow translation to work server-side
  • Scoreboard (similar to translation)
  • Keybind (similar to translation)

@Defman Defman marked this pull request as draft March 8, 2021 12:32
@Defman Defman added enhancement New feature or request help wanted Extra attention is needed labels Mar 8, 2021
@Defman Defman requested a review from caelunshun March 8, 2021 12:33
caelunshun
caelunshun reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@caelunshun caelunshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, thanks!

feather/common/src/chat.rs
@@ -51,21 +51,13 @@ impl ChatBox {
/// Represents a chat message.
#[derive(Debug, Clone)]
pub struct ChatMessage {
kind: ChatKind,
message: Text,
pub kind: ChatKind,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be kept provide for encapsulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caelunshun caelunshun caelunshun left review comments

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Defman @caelunshun