Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeSendSync/ThreadPinned<T>: Data race allowed on T #557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kuzeyardabulut
Copy link

Hi,
I found a memory-safety/soundness issue in this crate while scanning Rust code for potential vulnerabilities. This PR contains a fix for the issue.

Issue Description

ThreadPinned<T> unconditionally implements Sync. This allows users to create data races on T: !Sync. Such data races can lead to undefined behavior.

unsafe impl<T> Send for ThreadPinned<T> {}
unsafe impl<T> Sync for ThreadPinned<T> {}

same

unsafe impl<T> Send for UnsafeSendSync<T> {}
unsafe impl<T> Sync for UnsafeSendSync<T> {}

@MalbaCato
Copy link

did you also pr this "fix" to std::sync::Exclusive?

@kuzeyardabulut
Copy link
Author

did you also pr this "fix" to std::sync::Exclusive?

What do u mean?

@kuzeyardabulut kuzeyardabulut changed the title UnsafeSendSync/ThreadPinned<T>: Data race allowed on T #3363 UnsafeSendSync/ThreadPinned<T>: Data race allowed on T Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants