Removed the from_display_name function from Item
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the `Item` generator to not generate `from_display_name` function because of it's abiguos - Updated `libcraft-generators` README to include all currently implemented generators
kallekankaanpaa
changed the title
from_display_name fuction from Itemfrom_display_name fuction from Item (#14)
kallekankaanpaa
changed the title
from_display_name fuction from Item (#14)from_display_name fuction from Item
kallekankaanpaa
changed the title
from_display_name fuction from Itemfrom_display_name function from Item
PauMAVA
approved these changes
Feb 26, 2021
caelunshun
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Itemgenerator to not generatefrom_display_namefunction because of it's abiguos
libcraft-generatorsREADME to include all currentlyimplemented generators
closes #14